Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-cookie-banner): DSW-2679 CDN build output #2193

Merged
merged 21 commits into from
Mar 6, 2025
Merged

feat(pie-cookie-banner): DSW-2679 CDN build output #2193

merged 21 commits into from
Mar 6, 2025

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Feb 6, 2025 •
edited by fernandofranca
Loading

Describe your changes (can list changeset entries if preferable)

  • Adds a build step to pie-cookie-banner to output a fully independent build artifact that can be provided by CDN to consumers that cannot install and build individual components. This is an edge-case and the recommended way to use the component.
  • Adds a new action to publish the built stand-alone cookie banner to a CDN after the Version Packages PR is merged

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • If changes will affect consumers of the package, I have created a changeset entry.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR N/A
NextJS 14 deployment N/A
Nuxt 3 deployment N/A
Vanilla deployment N/A

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @fernandofranca

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Reviewer 2 - @JoshuaNg2332

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

@jamieomaguire jamieomaguire added the work-in-progress This pull request is still a work in progress and may not be ready for review label Feb 6, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bacd841

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-cookie-banner Patch
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire jamieomaguire changed the title feat(pie-cookie-banner): DSW-2679 cDN build output feat(pie-cookie-banner): DSW-2679 CDN build output Feb 6, 2025
@jamieomaguire jamieomaguire marked this pull request as ready for review February 25, 2025 14:28
@jamieomaguire jamieomaguire requested review from a team as code owners February 25, 2025 14:28
@jamieomaguire jamieomaguire force-pushed the dsw-2679-cdn-cookie-banner branch from b72c4e6 to cc6eeba Compare February 25, 2025 14:30
@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

An unexpected error occurred during the snapshot release process:

Command failed with exit code 1: yarn changeset:version --snapshot snapshot-release

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire jamieomaguire force-pushed the dsw-2679-cdn-cookie-banner branch from 8a6c893 to 8c81a99 Compare February 25, 2025 15:59
@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@siggerzz siggerzz requested a review from a team as a code owner February 27, 2025 13:14
@siggerzz siggerzz force-pushed the dsw-2679-cdn-cookie-banner branch from a686ac6 to bf0b7d7 Compare March 5, 2025 16:33
@siggerzz siggerzz merged commit 6b6e7b3 into main Mar 6, 2025
28 checks passed
@siggerzz siggerzz deleted the dsw-2679-cdn-cookie-banner branch March 6, 2025 09:30
@pie-design-system-bot pie-design-system-bot mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggerzz siggerzz siggerzz left review comments

@fernandofranca fernandofranca fernandofranca approved these changes

@JoshuaNg2332 JoshuaNg2332 JoshuaNg2332 approved these changes

Assignees

@jamieomaguire jamieomaguire

Labels
ci components pie-cookie-banner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamieomaguire @pie-design-system-bot @fernandofranca @siggerzz @JoshuaNg2332